fix: Skylighting code blocks in Typst lack proper block styling#14131
Open
gordonwoodhull wants to merge 1 commit intomainfrom
Open
fix: Skylighting code blocks in Typst lack proper block styling#14131gordonwoodhull wants to merge 1 commit intomainfrom
gordonwoodhull wants to merge 1 commit intomainfrom
Conversation
Fixes #14126 The Pandoc-generated Skylighting function uses `block(fill: bgcolor, blocks)` which lacks width, inset, and radius. This temporarily overrides it from the typst-brand-yaml Lua filter to add `width: 100%`, `inset: 8pt`, `radius: 2pt`, matching the styling of native code blocks. Also fixes brand `monospace-block.background-color` not applying to Skylighting output (since `#show raw.where(block: true)` doesn't match `#Skylighting()` calls). This override will be removed once the fix is upstreamed to Skylighting.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#let Skylighting()Typst function to addwidth: 100%,inset: 8pt, andradius: 2ptto theblock()call, matching native code block stylingmonospace-block.background-colornot applying to Skylighting output (since#show raw.where(block: true)doesn't match#Skylighting()calls)Fixes #14126
Test plan